Remove support for pre-2.0 versions of Chapel #3477
Conversation
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
…Remove Commands.chpl from git tree. Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
…uctionMsg) Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
bmcdonald3
left a comment
bmcdonald3
left a comment
There was a problem hiding this comment.
🎉 very happy to see those old compat modules going away.
Do we still need the 2.0+ compat modules? Are there differences between 2.0 and 2.1/2.2 that we are tracking?
I know that I have seen a couple of deprecations popping up, but haven't looked deeply enough to know if they are deprecations requiring compat modules or ones where we can jsut make global changes. Have you looked into it enough to know the answer to that?
I don't think we need them currently, but I wanted to keep the framework in place for future changes. There may be some changes to the |
stress-tess
left a comment
stress-tess
left a comment
There was a problem hiding this comment.
This looks great! Thanks so much @jeremiah-corrado!
As of Bears-R-Us/arkouda#3477, the Chapel frontend bindings are required to build Arkouda. This is needed to support a build script that handles the new `registerCommand` and `instantiateAndRegister` annotations added in Bears-R-Us/arkouda#3371. This PR adds a step to `pip install` the frontend bindings as a part of the nightly testing setup for arkouda. [ reviewed by @bmcdonald3 ] - thanks!
3 participants
Removes support for Chapel 1.32 and 1.33. CI is updated to run on version 2.1 with compatibility checking for version 2.0.
Modifies the makefile to run
register-commands(added here) when building the server. This requires installing the chapel-frontend python bindings. They can be installed with(cd $CHPL_HOME/tools/chapel-py && pip install .). The CI script was modified to include this step before building the server.Commands.chplis removed from git tracking because it is now automatically generated when runningmake.