Array transfer perf fix #3671
Merged
Array transfer perf fix #3671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
…ors. Convert array and tondarray commands to use new annotations Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
jeremiah-corrado
requested review from
bmcdonald3 and
stress-tess
and removed request for
bmcdonald3
stress-tess
reviewed
Aug 16, 2024
Member
stress-tess
left a comment
stress-tess
left a comment
There was a problem hiding this comment.
looks good! My only question is whether the proto test client file was committed on purpose. If so, we actually moved the tests to the tests directory, so if you could updated that version of client_test instead that would be great
Signed-off-by: Jeremiah Corrado <jeremiah.corrado@hpe.com>
stress-tess
approved these changes
Aug 19, 2024
stonea
added a commit
to chapel-lang/chapel
that referenced
this pull request
Sep 5, 2024
Annotations impacting array transfer performance: ``` 8/19/24: - Array transfer perf fix (Bears-R-Us/arkouda#3671) 8/27/24: - Fix performance regression in to_ndarray (Bears-R-Us/arkouda#3697) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recent regression in array transfer performance. The regression was caused by:
in-intent insendRepMsg(added here) leading to an extra copy of thebytespayload. Fixed by not referencingrepMsgafter it gets handed off tosendRepMsg.executeCommandhere. Fixed by moving error handling back out into serverDaemon.Also converts "tondarray" and "array" commands to use instantiateAndRegister annotation.