Part of argTypeReductionMessage refactor #3845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
refactor-argTypeReductionMessage-pt1
branch
from
0ed2049 to
ede7cb4
Compare
ajpotts
force-pushed
the
refactor-argTypeReductionMessage-pt1
branch
from
0b4d211 to
0efe581
Compare
stonea
added a commit
to chapel-lang/chapel
that referenced
this pull request
Oct 30, 2024
Adds an annotation for a recent Arkouda reduction performance regression: - initial regression caused by: Bears-R-Us/arkouda#3845 - resolved by: Bears-R-Us/arkouda#3874 [Reviewed by nobody; annotations update]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of argTypeReductionMessage refactor
Adds
sum,prod,min, andmaxfunctions. Also, theaxisargument is added tosum,prod,minandmaxinpdarrayclass.py, and corresponding unit tests are added.This PR has the additions from PR #3834, without stripping out the old code. This is to isolate a problem that was causing the CI to hang.