Closes #3912: failing unit test test_is_locally_sorted_multidim unde… #3913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3912_failing_unit_test_test_is_locally_sorted_multidim_under_gasnet_nl==2
branch
3 times, most recently
from
7f18962 to
09126b1
Compare
ajpotts
force-pushed
the
3912_failing_unit_test_test_is_locally_sorted_multidim_under_gasnet_nl==2
branch
2 times, most recently
from
e01a742 to
a18ff2d
Compare
jaketrookman
approved these changes
Nov 21, 2024
ajpotts
force-pushed
the
3912_failing_unit_test_test_is_locally_sorted_multidim_under_gasnet_nl==2
branch
2 times, most recently
from
c72af7f to
0258cc5
Compare
…idim under gasnet nl==2
ajpotts
force-pushed
the
3912_failing_unit_test_test_is_locally_sorted_multidim_under_gasnet_nl==2
branch
from
0258cc5 to
0960010
Compare
…ted_multidim_under_gasnet_nl==2
…ted_multidim_under_gasnet_nl==2
drculhane
approved these changes
Dec 5, 2024
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the unit tests that fail when the number of locales is 2. The reason is that a small random array will occasionally have a sorted dimension, causing
is_locally_sorted(a, axis=axis)to haveTruevalues. The solution is to increase the array dimension, and also skip the test for a larger number of locales.Closes #3912: failing unit test test_is_locally_sorted_multidim under gasnet nl==2