Part 1 of #3933: failing make install-arrow #3936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3933_failing_make_install-arrow
branch
2 times, most recently
from
7313929 to
0bcd3c3
Compare
ajpotts
force-pushed
the
3933_failing_make_install-arrow
branch
from
2544cc0 to
4bcaa26
Compare
ajpotts
changed the title
ajpotts
force-pushed
the
3933_failing_make_install-arrow
branch
from
6bf28a4 to
1f8cb1d
Compare
drculhane
approved these changes
Dec 13, 2024
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
Tested similarly to how I tested 3940, and it works as expected. Nice job.
ajpotts
force-pushed
the
3933_failing_make_install-arrow
branch
from
1f8cb1d to
a79b375
Compare
jabraham17
pushed a commit
to jabraham17/arkouda
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Amanda Potts <ajpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
make install-arrowsection of the Makefile. The previous version was failing to build arrow. This version should successfully build. It also allows the addition of theDEP_BUILD_DIRoption, which allows the user to specify a build directory. It can be called as follows:If this directory contains a file of the form
apache-arrow-apt-source*.deb, it will use that file instead of fetching the file withwget. This will be useful for offline builds.The downsides are that it automatically selects the latest arrow version (unless using the
DEP_BUILD_DIRoption), and it requires either to be run with root, or it will make asudocall which will require the user to enter a password.Part of #3933: failing make install-arrow