Closes #3939: install-deps to work offline #3940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3939_install_deps_to_work_offline
branch
from
a55b3e5 to
6425ce3
Compare
drculhane
approved these changes
Dec 13, 2024
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
I tested this on Tuxedo (an Ubuntu variant) and Alma Linux (which our customer suggested). I did an install once with the Internet, to ensure the files where there. Then I disconnected from the Internet, and ran make install-zmq, make install-hdf5, make install-iconv and make install-idn2, all with the appropriate DEP_BUILD_DIR= argument. They all worked.
ajpotts
force-pushed
the
3939_install_deps_to_work_offline
branch
from
dd6ddb0 to
2d7c708
Compare
jabraham17
pushed a commit
to jabraham17/arkouda
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Amanda Potts <ajpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Makefile such that
make install-deps DEP_INSTALL_DIR=<directory>can be called, and the install script will attempt to look for the necessary files in
DEP_INSTALL_DIRbefore calling out to the network. This will be useful for offline builds.make install-arrowis being handled under #3933.Closes #3939: install-deps to work offline