Closes 3943 issue with reshape #3947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
approved these changes
Dec 18, 2024
Contributor
ajpotts
left a comment
ajpotts
left a comment
There was a problem hiding this comment.
Looks good. Thanks for taking this one!
jabraham17
pushed a commit
to jabraham17/arkouda
that referenced
this pull request
Jan 21, 2025
* Ready for testing * Addresses flake8 error --------- Co-authored-by: drculhane <drculhane@users.noreply.github.com> Co-authored-by: ajpotts <amanda.j.potts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3943
Slight changes to reshape to allow for a single integer argument. Had to make some additional changes so that the use of reshape by slice wouldn't cause problems. Passes all tests.
Added a test to test_reshape. Previously it changed a (4) to a (2,2). Now it changes it back to (4) also.