Part 4 of #3957: simplify offline builds #3965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasslitvinov
approved these changes
Jan 8, 2025
jaketrookman
approved these changes
Jan 8, 2025
jabraham17
pushed a commit
to jabraham17/arkouda
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Amanda Potts <ajpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a minor change to the Makefile to have the install targets (for example
install-arrow) depend on the associated download target (for examplearrow-download-source), instead of callingmake, which is more inefficient.Thanks to @vasslitvinov for recommending this improvement.