Closes #3974 permutation performance fix #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3974_permute_performance_fix
branch
3 times, most recently
from
7e4feaf to
f697c97
Compare
ajpotts
changed the title
ajpotts
force-pushed
the
3974_permute_performance_fix
branch
from
58b538a to
b7e942b
Compare
drculhane
reviewed
Jan 22, 2025
drculhane
approved these changes
Jan 22, 2025
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
Passes tests, looks solid, and I have only the comment about passing "method" from python to Chapel, but not using it there.
jaketrookman
approved these changes
Jan 23, 2025
ajpotts
force-pushed
the
3974_permute_performance_fix
branch
from
36d033d to
de6b60d
Compare
ajpotts
force-pushed
the
3974_permute_performance_fix
branch
from
8bfd31f to
d11f0b9
Compare
drculhane
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
methodargument to thepermutationfunction. Whenmethod="ArgSort", thepermutationfunction will use anak.argsorton a random array of floats to generate the permutation. Whenmethod="FisherYates", thepermutationfunction will use the chapelpermutationfunction which is serial and relies on the Fisher Yates algorithm. Fisher Yates is slower, but uses less memory as it is all in place.Closes #3974 permutation performance fix