Closes-4092 aligns ak.transpose to numpy transpose #4174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drculhane
changed the title
drculhane
force-pushed
the
Closes-4092-Revised
branch
from
96314c7 to
6f6c3a0
Compare
jaketrookman
approved these changes
Mar 13, 2025
ajpotts
reviewed
Mar 17, 2025
drculhane
force-pushed
the
Closes-4092-Revised
branch
from
6f6c3a0 to
4c605de
Compare
ajpotts
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4092
This replaces the existing ak.transpose with code that calls permuteDims on the server. In this way, it matches the previous ak.transpose for 2D pdarrays, and also works for 1D and >= 3D cases, matching np.transpose.