Fix distributed array creation and sorting issues #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
The new implementation of makeDistArray exposed that we were using a non distributed sort in SegStringSort.chpl and this replaces that with the dynamicRadixSort. That in term caused issues with the module initialzation order which cased build failures. This factors out the dynamicTwoArrayRadixSort into it's own small module to avoid this issue Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
e-kayrakli
reviewed
Apr 17, 2025
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
ShreyasKhandekar
force-pushed
the
make-dist-array-always-dist
branch
from
e4cec8d to
73356c2
Compare
e-kayrakli
approved these changes
Apr 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
makeDistArrayconsistently creates distributed arrays and update sorting implementations to utilize the newmakeDistArray.Address build issues caused by the previous sorting method by refactoring the sorting logic into a dedicated module.
Closes #4233