Skip to content

Conversation

@1RyanK
Copy link
Contributor

@1RyanK 1RyanK commented Apr 29, 2025

Categorical support didn't take that much reworking. Includes unit test.

Closes #4313: ak.merge does not support Categorical

@1RyanK 1RyanK marked this pull request as ready for review April 29, 2025 13:33
@1RyanK 1RyanK force-pushed the 4313-ak.merge_does_not_support_Categorical branch from 3310edd to b064986 Compare April 29, 2025 13:34
@1RyanK 1RyanK force-pushed the 4313-ak.merge_does_not_support_Categorical branch from b064986 to 51014df Compare April 29, 2025 17:03
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ajpotts ajpotts added this pull request to the merge queue Apr 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 30, 2025
@1RyanK 1RyanK added this pull request to the merge queue May 1, 2025
Merged via the queue into Bears-R-Us:master with commit 81d161c May 1, 2025
24 checks passed
@1RyanK 1RyanK deleted the 4313-ak.merge_does_not_support_Categorical branch June 3, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ak.merge does not support Categorical

3 participants