Part of #3964: Refactor benchmark handling of running mode #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasslitvinov
approved these changes
Apr 30, 2025
Contributor
vasslitvinov
left a comment
vasslitvinov
left a comment
There was a problem hiding this comment.
This is a good step forward, however it addresses only part of #3964. I suggest to keep 3964 open.
ajpotts
changed the title
ajpotts
force-pushed
the
3964_Refactor_benchmark_handling_of_running_mode
branch
3 times, most recently
from
0a2c6ab to
6d3aa4d
Compare
ajpotts
force-pushed
the
3964_Refactor_benchmark_handling_of_running_mode
branch
from
6d3aa4d to
0f743c7
Compare
vasslitvinov
reviewed
May 1, 2025
vasslitvinov
reviewed
May 1, 2025
vasslitvinov
reviewed
May 1, 2025
vasslitvinov
approved these changes
May 1, 2025
ajpotts
force-pushed
the
3964_Refactor_benchmark_handling_of_running_mode
branch
2 times, most recently
from
9797880 to
f9dea9c
Compare
vasslitvinov
reviewed
May 2, 2025
1RyanK
approved these changes
May 2, 2025
ajpotts
force-pushed
the
3964_Refactor_benchmark_handling_of_running_mode
branch
from
f9dea9c to
149d713
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address some issues brought up in #3964 regarding the handling of running mode in the benchmarks. Some improvements:
pytest_adoptionthat cover the environment variables set inbenchmark.ini. This clarifies that directly specified arguments take precedent, followed by the value of the corresponding environment variable, and the default value is used as last resort.server=pytest.hostis used instart_arkouda_server(host=pytest.host, numlocales=nl, port=pytest.port)andak.connect(server=pytest.host, port=pytest.port, timeout=pytest.timeout)to ensure the tests connect to the same server that was started during the tests.Part of #3964: Refactor benchmark handling of running mode