Adds negative axis coverage to ak.repeat, ak.argmin, ak.argmax, Closes 4407 and 4421 #4408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would you please add a description the PR? |
drculhane
force-pushed
the
Closes-4407
branch
4 times, most recently
from
e3219e8 to
24792f7
Compare
drculhane
changed the title
ajpotts
approved these changes
May 20, 2025
Contributor
ajpotts
left a comment
ajpotts
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
ajpotts
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4407 and #4421
Numpy functions allow for negative numbers in the axis argument (e.g. -1 means the last axis, -2 the next-to-last, etc). Arkouda has such functionality server-side, but it's not used consistently. This PR is part of a series that aims to correct that.
Update: also adds negative axis coverage for argmin and argmax. Renames the new chapel function validateNegativeAxis to validateNegativeAxes, since "Axes" already existed, and this is just a case of overloading it.