Closes #2998: diff function #4418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
reviewed
May 16, 2025
1RyanK
force-pushed
the
2998-diff_function
branch
3 times, most recently
from
f32dcc0 to
9396830
Compare
ajpotts
reviewed
May 20, 2025
1RyanK
force-pushed
the
2998-diff_function
branch
4 times, most recently
from
cad2759 to
cfe39f6
Compare
drculhane
approved these changes
May 28, 2025
1RyanK
force-pushed
the
2998-diff_function
branch
from
2738598 to
a01521c
Compare
drculhane
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
difffunction already existed thanks toarray_api, just added it in here. Ordinarily it would be in some kind of utility functions, but since that's where it's suggested thatanyandallbe as well, I put this in the same file. Mostly ripped off the existing unit tests but added some things. Seemed to be unhappy with bool, so I made a small change to Chapel code.Closes #2998: diff function