Closes #4426 add missing __all__ #4427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
4426_add_missing_all
branch
from
6ea69c1 to
525e9d7
Compare
ajpotts
force-pushed
the
4426_add_missing_all
branch
2 times, most recently
from
50c6172 to
439bcb2
Compare
ajpotts
force-pushed
the
4426_add_missing_all
branch
from
439bcb2 to
e7c19ed
Compare
drculhane
approved these changes
May 21, 2025
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
Passes all the tests. Looks good.
1RyanK
approved these changes
May 21, 2025
Contributor
1RyanK
left a comment
1RyanK
left a comment
There was a problem hiding this comment.
Looking at the arkouda-util script, is this replacing * with all of the things in __all__? I feel like it would be nice if we could limit to only the things used, but maybe that's a little idealistic of me. The tradeoff is that it would make things maybe difficult to check to see if they're imported and to maintain the list of imported things. I guess for things like init.py you probably don't want to do that anyways...?
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
__all__declarations to all modules where it was missing. This also removesimport *statements from the project.Closes #4426 add missing all