Closes #4460: Simplify and extend logic in binopvs #4563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1RyanK
force-pushed
the
4460-Simplify_and_extend_logic_in_binopvs
branch
2 times, most recently
from
2c1103e to
39fb08d
Compare
ajpotts
approved these changes
Jun 9, 2025
drculhane
approved these changes
Jun 9, 2025
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
This is good work. I think in the future we might want to expand test_can_cast, but that's for another day.
e-kayrakli
approved these changes
Jun 9, 2025
Contributor
e-kayrakli
left a comment
e-kayrakli
left a comment
There was a problem hiding this comment.
The changes look nice and the new code is certainly much more readable. Thanks!
Reviewing the diff is not super-easy, though. Based on that, I would be definitely on the look out for correctness and performance issues after this PR is merged to ensure that there is no regression. I am especially worried about some edge-case implementations and whether we'd be losing something there.
1RyanK
force-pushed
the
4460-Simplify_and_extend_logic_in_binopvs
branch
from
0730810 to
7a9e6bb
Compare
1RyanK
force-pushed
the
4460-Simplify_and_extend_logic_in_binopvs
branch
from
7a9e6bb to
24aa256
Compare
ajpotts
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied mostly the same changes to
binopvsandbinopsvfrombinopvv. This could possibly benefit from being collapsed into one function that works regardless of vector or scalar.Closes #4460: Simplify and extend logic in binopvs
Closes #4461: Simplify and extend logic in binopsv