Closes #4621: Create a max_bits_list function #4622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1RyanK
force-pushed
the
4621-Create_a_max_bits_list_function
branch
2 times, most recently
from
dfc081f to
ffef427
Compare
1RyanK
force-pushed
the
4621-Create_a_max_bits_list_function
branch
from
ffef427 to
9c44c0b
Compare
drculhane
approved these changes
Jul 1, 2025
Contributor
drculhane
left a comment
drculhane
left a comment
There was a problem hiding this comment.
Following our discussion, I understand the intent, and definitely approve. Always better to have the code in one place than repeated multiple times.
ajpotts
approved these changes
Jul 8, 2025
Contributor
ajpotts
left a comment
ajpotts
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding the warning in.
drculhane
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to create a helper private function to do this. I don't think this really needs to be exposed to users, so I put an underscore in front of the name.
Closes #4621: Create a max_bits_list function