Closes #4498: Create a repartitionByLocale function #4647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1RyanK
force-pushed
the
4498-Create_a_repartitionByLocale_function
branch
from
2763a5f to
7dab6c0
Compare
1RyanK
force-pushed
the
4498-Create_a_repartitionByLocale_function
branch
from
7dab6c0 to
c29a858
Compare
ajpotts
previously approved these changes
Jun 30, 2025
Contributor
ajpotts
left a comment
ajpotts
left a comment
There was a problem hiding this comment.
Interesting idea and the code looks good. I would like to see a performance test before merging it in, since flatten is used a lot in the code base.
1RyanK
force-pushed
the
4498-Create_a_repartitionByLocale_function
branch
from
3c1bd7d to
af6eafc
Compare
1RyanK
force-pushed
the
4498-Create_a_repartitionByLocale_function
branch
from
af6eafc to
8504f4b
Compare
ajpotts
approved these changes
Jul 28, 2025
drculhane
pushed a commit
to drculhane/arkouda
that referenced
this pull request
Aug 20, 2025
…R-Us#4647) Created the repartitionByLocale function ~~changing the behavior of flatten to demonstrate as a proof of concept. Seems to pass multilocale, multidimensional tests~~. Previously I was using flatten to demonstrate it worked, and it did work and pass tests there. Since it would be difficult to directly test this code otherwise, I think this should be treated as passing tests. Closes Bears-R-Us#4498: Create a repartitionByLocale function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the repartitionByLocale function
changing the behavior of flatten to demonstrate as a proof of concept. Seems to pass multilocale, multidimensional tests.Previously I was using flatten to demonstrate it worked, and it did work and pass tests there. Since it would be difficult to directly test this code otherwise, I think this should be treated as passing tests.
Closes #4498: Create a repartitionByLocale function