Skip to content

Conversation

@ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Jul 22, 2025

Fixes a bug where empty Strings objects could not be instantiated or copied.

Closes #4725: ak.array for empty strings

@ajpotts ajpotts force-pushed the 4725_ak.array_for_empty_strings branch 3 times, most recently from cae9cc4 to 5735b0b Compare July 23, 2025 18:21
@ajpotts ajpotts force-pushed the 4725_ak.array_for_empty_strings branch from 5735b0b to 91b7edd Compare July 23, 2025 19:09
@ajpotts ajpotts added the blocking This is blocking a developer from completing a task they are actively working. label Jul 24, 2025
@ajpotts ajpotts marked this pull request as ready for review July 24, 2025 18:27
jaketrookman
jaketrookman previously approved these changes Jul 25, 2025
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ajpotts ajpotts changed the base branch from master to main July 25, 2025 14:06
@ajpotts ajpotts dismissed jaketrookman’s stale review July 25, 2025 14:06

The base branch was changed.

Copy link
Contributor

@1RyanK 1RyanK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes unit tests.

@ajpotts ajpotts added this pull request to the merge queue Jul 25, 2025
Merged via the queue into Bears-R-Us:main with commit a99681c Jul 25, 2025
27 checks passed
drculhane pushed a commit to drculhane/arkouda that referenced this pull request Aug 20, 2025
Fixes a bug where empty `Strings` objects could not be instantiated or
copied.

Closes Bears-R-Us#4725:  ak.array for empty strings

Co-authored-by: ajpotts <ajpotts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocking This is blocking a developer from completing a task they are actively working.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ak.array for empty strings

4 participants