Skip to content

Composer 2.8.9#25

Merged
N6REJ merged 1 commit intomainfrom
2.8.9
Jul 6, 2025
Merged

Composer 2.8.9#25
N6REJ merged 1 commit intomainfrom
2.8.9

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Jul 2, 2025

PR Type

Enhancement


Description

  • Add Composer 2.8.9 version support

  • Update bundle release to 2025.7.2

  • Configure new version with batch script and JSON config

  • Add release URL for version 2.8.9


Changes diagram

flowchart LR
  A["New Composer 2.8.9"] --> B["Batch Script"]
  A --> C["Configuration Files"]
  A --> D["Release Properties"]
  B --> E["composer.bat"]
  C --> F["bearsampp.conf"]
  C --> G["composer.json"]
  D --> H["releases.properties"]
Loading

Changes walkthrough 📝

Relevant files
Configuration changes
composer.bat
Add Windows batch script for Composer                                       

bin/composer2.8.9/composer.bat

  • Create Windows batch script for Composer execution
  • Set COMPOSER_HOME environment variable
  • Execute composer.phar with passed arguments
  • +3/-0     
    bearsampp.conf
    Add Bearsampp configuration for Composer 2.8.9                     

    bin/composer2.8.9/bearsampp.conf

  • Define Composer version as 2.8.9
  • Set executable to composer.bat
  • Configure bundle release placeholder
  • +4/-0     
    composer.json
    Add Composer JSON configuration file                                         

    bin/composer2.8.9/composer.json

  • Configure cache directory path
  • Add PHPUnit development dependency
  • Set up Composer project configuration
  • +8/-0     
    build.properties
    Update bundle release version                                                       

    build.properties

    • Update bundle release from 2025.4.18 to 2025.7.2
    +1/-1     
    releases.properties
    Add Composer 2.8.9 release URL                                                     

    releases.properties

    • Add download URL for Composer 2.8.9 release
    +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @jwaisner jwaisner requested a review from N6REJ as a code owner July 2, 2025 22:08
    @jwaisner jwaisner added the enhancement ✨ Improve program label Jul 2, 2025
    @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Path Syntax

    The cache directory path uses a custom placeholder syntax ~BEARSAMPP_LIN_PATH~ which may not be standard JSON or Composer configuration. Verify this placeholder is properly resolved by the Bearsampp system.

      "cache-dir": "~BEARSAMPP_LIN_PATH~/tmp/composer"
    },
    Placeholder Usage

    The @RELEASE_VERSION@ placeholder should be verified to ensure it gets properly substituted during the build process, as an unresolved placeholder could cause runtime issues.

    bundleRelease = "@RELEASE_VERSION@"

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Add error handling for dependencies

    Add error handling to check if PHP is available and composer.phar exists before
    execution. This prevents cryptic error messages when dependencies are missing.

    bin/composer2.8.9/composer.bat [1-3]

     @echo off
     set COMPOSER_HOME=%~dp0
    -@php "%~dp0composer.phar" %*
    +if not exist "%~dp0composer.phar" (
    +    echo Error: composer.phar not found in %~dp0
    +    exit /b 1
    +)
    +@php "%~dp0composer.phar" %* || exit /b %errorlevel%
    • Apply / Chat
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion improves the script's robustness by adding checks for composer.phar and propagating the exit code, which is good practice for error handling.

    Medium
    • More

    @N6REJ N6REJ merged commit 7e33cb6 into main Jul 6, 2025
    @N6REJ N6REJ deleted the 2.8.9 branch July 6, 2025 05:23
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    enhancement ✨ Improve program

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants