NodeJS 22.11.0 & 23.1.0

[jwaisner]

PR Type

enhancement, configuration changes

---

Description

• Added new Node.js versions 22.11.0 and 23.1.0 with corresponding configuration and launch scripts.
• Configured npm settings for both Node.js versions.
• Updated release properties to include new Node.js versions.
• Adjusted bundle release date in build properties.

---

Changes walkthrough 📝

Relevant files

Configuration changes

16 files launch.bat Add launch script for Node.js 22.11.0                                        bin/nodejs22.11.0/launch.bat Added launch script for Node.js version 22.11.0. Configures npm global settings. +12/-0    launch.bat Add launch script for Node.js 23.1.0                                          bin/nodejs23.1.0/launch.bat Added launch script for Node.js version 23.1.0. Configures npm global settings. +12/-0    bearsampp.conf Add configuration for Node.js 22.11.0                                        bin/nodejs22.11.0/bearsampp.conf Added configuration file for Node.js 22.11.0. +8/-0      .npmignore Add .npmignore for Node.js 22.11.0                                              bin/nodejs22.11.0/etc/.npmignore Added .npmignore file for Node.js 22.11.0. +1/-0      npmrc Add npmrc for Node.js 22.11.0                                                        bin/nodejs22.11.0/etc/npmrc Added npm configuration file for Node.js 22.11.0. +5/-0      npmrc.ber Add backup npmrc for Node.js 22.11.0                                          bin/nodejs22.11.0/etc/npmrc.ber Added backup npm configuration file for Node.js 22.11.0. +5/-0      npmrc Add npmrc for Node.js 22.11.0                                                        bin/nodejs22.11.0/node_modules/npm/npmrc Added npmrc file for Node.js 22.11.0. +1/-0      npmrc.ber Add backup npmrc for Node.js 22.11.0                                          bin/nodejs22.11.0/node_modules/npm/npmrc.ber Added backup npmrc file for Node.js 22.11.0. +1/-0      bearsampp.conf Add configuration for Node.js 23.1.0                                          bin/nodejs23.1.0/bearsampp.conf Added configuration file for Node.js 23.1.0. +8/-0      .npmignore Add .npmignore for Node.js 23.1.0                                                bin/nodejs23.1.0/etc/.npmignore Added .npmignore file for Node.js 23.1.0. +1/-0      npmrc Add npmrc for Node.js 23.1.0                                                          bin/nodejs23.1.0/etc/npmrc Added npm configuration file for Node.js 23.1.0. +5/-0      npmrc.ber Add backup npmrc for Node.js 23.1.0                                            bin/nodejs23.1.0/etc/npmrc.ber Added backup npm configuration file for Node.js 23.1.0. +5/-0      npmrc Add npmrc for Node.js 23.1.0                                                          bin/nodejs23.1.0/node_modules/npm/npmrc Added npmrc file for Node.js 23.1.0. +1/-0      npmrc.ber Add backup npmrc for Node.js 23.1.0                                            bin/nodejs23.1.0/node_modules/npm/npmrc.ber Added backup npmrc file for Node.js 23.1.0. +1/-0      build.properties Update bundle release date                                                              build.properties Updated bundle release date. +1/-1      releases.properties Add release URLs for Node.js 22.11.0 and 23.1.0                    releases.properties Added release URLs for Node.js versions 22.11.0 and 23.1.0. +2/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Path Consistency Ensure that the path variables are consistently set and used across different Node.js versions. Verify that the BEARSAMPP_NODEJS_PATH is correctly set and used in all related scripts. Configuration Consistency Check that the npm configuration settings are consistent across different Node.js versions and align with the project's requirements. Verify that paths and global settings are correctly specified. Version Management Confirm that the bundle release date is correctly updated and consistent with the new Node.js versions being added. Ensure this change doesn't affect other parts of the build process.

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Ensure proper execution flow by using the CALL command for external batch files Use the CALL command when executing nodevars.bat to ensure that control returns to the current script after nodevars.bat finishes executing. bin/nodejs22.11.0/launch.bat [10] -"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global +CALL "%BEARSAMPP_NODEJS_PATH%\nodevars.bat" +"%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global Apply this suggestion Suggestion importance[1-10]: 8 Why: Using the CALL command ensures that control returns to the script after executing nodevars.bat, which is a best practice for maintaining proper script execution flow.	8
Enhancement	Improve script robustness and maintainability by using pushd/popd instead of SETLOCAL/ENDLOCAL Consider using the pushd and popd commands to change the current directory temporarily instead of using SETLOCAL and ENDLOCAL. This can make the script more robust and easier to maintain. bin/nodejs22.11.0/launch.bat [1-12] @ECHO OFF -SETLOCAL EnableDelayedExpansion +pushd %~dp0 -SET BEARSAMPP_NODEJS_PATH=%~dp0 -SET BEARSAMPP_NODEJS_PATH=!BEARSAMPP_NODEJS_PATH:~0,-1! +SET BEARSAMPP_NODEJS_PATH=%CD% SET BEARSAMPP_NODEJS_NPM_PATH=%BEARSAMPP_NODEJS_PATH%\node_modules\npm SET BEARSAMPP_NODEJS_CONFIG_PATH=%BEARSAMPP_NODEJS_NPM_PATH%\npmrc ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH% -"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global +CALL "%BEARSAMPP_NODEJS_PATH%\nodevars.bat" +"%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global -ENDLOCAL +popd Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion to use pushd/popd instead of SETLOCAL/ENDLOCAL can improve script robustness and maintainability by managing directory changes more effectively. However, it may not be necessary if the current implementation works as intended.	7
	Maintain consistency and improve script robustness across different Node.js version launch scripts Apply the same improvements suggested for the Node.js 22.11.0 launch script to this script for consistency and better practices across different Node.js versions. bin/nodejs23.1.0/launch.bat [1-12] @ECHO OFF -SETLOCAL EnableDelayedExpansion +pushd %~dp0 -SET BEARSAMPP_NODEJS_PATH=%~dp0 -SET BEARSAMPP_NODEJS_PATH=!BEARSAMPP_NODEJS_PATH:~0,-1! +SET BEARSAMPP_NODEJS_PATH=%CD% SET BEARSAMPP_NODEJS_NPM_PATH=%BEARSAMPP_NODEJS_PATH%\node_modules\npm SET BEARSAMPP_NODEJS_CONFIG_PATH=%BEARSAMPP_NODEJS_NPM_PATH%\npmrc ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH% -"%BEARSAMPP_NODEJS_PATH%\nodevars.bat" & "%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global +CALL "%BEARSAMPP_NODEJS_PATH%\nodevars.bat" +"%BEARSAMPP_NODEJS_PATH%\npm" config set globalconfig "%BEARSAMPP_NODEJS_CONFIG_PATH%" --global -ENDLOCAL +popd Apply this suggestion Suggestion importance[1-10]: 7 Why: Applying the same improvements to the Node.js 23.1.0 script ensures consistency and robustness across different versions, which is beneficial for maintainability.	7
	Enhance version compatibility management by adding the engine-strict setting to the npm configuration Consider adding the engine-strict=true setting to enforce the use of the specified Node.js version in projects, which can help prevent compatibility issues. bin/nodejs22.11.0/etc/npmrc [1-5] cache = ~BEARSAMPP_WIN_PATH~\tmp\npm-cache globalconfig = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs22.11.0\etc\npmrc globalignorefile = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs22.11.0\etc\.npmignore init-module = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs22.11.0\etc\.npm-init.js userconfig = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs22.11.0\etc\npmrc +engine-strict = true Apply this suggestion Suggestion importance[1-10]: 6 Why: Adding the engine-strict setting can help enforce the use of the specified Node.js version, potentially preventing compatibility issues, though it may not be critical for all projects.	6

💡 Need additional feedback ? start a PR chat