Conversation
Review Summary by QodoAdd Ruby 4.0.2-1 release with configuration
WalkthroughsDescription• Add Ruby 4.0.2-1 release configuration and installation files • Update bundle release version to 2026.4.12 • Register new Ruby version in releases registry • Include RubyGems installation and update scripts Diagramflowchart LR
A["Ruby 4.0.2-1 Release"] --> B["Configuration Files"]
A --> C["Installation Scripts"]
A --> D["Version Registry"]
B --> E["bearsampp.conf"]
B --> F["rubygems.properties"]
C --> G["install.bat"]
D --> H["releases.properties"]
D --> I["build.properties"]
File Changes1. bin/ruby4.0.2-1/rubygems/install.bat
|
Code Review by Qodo
|
| set RUBYBINPATH=%~dp0..\bin | ||
| pushd %RUBYBINPATH% | ||
| set RUBYBINPATH=%CD% | ||
| popd |
There was a problem hiding this comment.
1. Unquoted pushd path 🐞 Bug ☼ Reliability
The new RubyGems installer batch script uses pushd %RUBYBINPATH% without quotes, which fails when the computed path contains spaces. This can break the Gradle processRubyGems step because Gradle executes the script from an absolute path where %~dp0 commonly includes spaces on Windows.
Agent Prompt
## Issue description
`bin/ruby4.0.2-1/rubygems/install.bat` uses `pushd %RUBYBINPATH%` without quotes. On Windows, this breaks when `%RUBYBINPATH%` contains spaces (common when the repo/build directory is under `C:\Users\<Name>\...`).
## Issue Context
Gradle executes this script via `cmd /c` and `%~dp0` expands to the absolute script directory. If that absolute path contains spaces, unquoted `pushd` will mis-parse the path.
## Fix Focus Areas
- bin/ruby4.0.2-1/rubygems/install.bat[1-6]
## Suggested change
- Use the safe quoting form for `set` and `pushd`, e.g.:
- `set "RUBYBINPATH=%~dp0..\bin"`
- `pushd "%RUBYBINPATH%"`
- Keep the rest of the logic unchanged.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
No description provided.