Skip to content

fix(files): java_maps#261

Merged
drav0011 merged 3 commits intoBedrockTweaks:develfrom
SquatchHunter:rp/parity/java_map
Oct 1, 2024
Merged

fix(files): java_maps#261
drav0011 merged 3 commits intoBedrockTweaks:develfrom
SquatchHunter:rp/parity/java_map

Conversation

@SquatchHunter
Copy link
Copy Markdown
Member

@SquatchHunter SquatchHunter commented Aug 12, 2024

fixes: #257

  • adds missing map_trial_chambers.png

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

* adds missing map_trial_chambers.png
@drav0011
Copy link
Copy Markdown
Member

Trial maps texture is pink/orange ish instead of black, could you update that?
image

@SquatchHunter
Copy link
Copy Markdown
Member Author

SquatchHunter commented Aug 26, 2024

where?
the wiki shows it as black
edit: the data table down the bottom shows it as black, the top section does actually show as orange, this is a case of bad UI/UX for the .wiki site sadly

@drav0011
Copy link
Copy Markdown
Member

I just went ingame without any resource packs an checked the color

* correct trial chambers map to orange coloured variant
@SquatchHunter
Copy link
Copy Markdown
Member Author

weird that git commit --amend requires a force push to update gh but oh well

@drav0011 this pr is ready for review

Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit 3eeb936 into BedrockTweaks:devel Oct 1, 2024
@SquatchHunter SquatchHunter deleted the rp/parity/java_map branch October 11, 2024 12:05
drav0011 added a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Parity] Java map

2 participants