Skip to content

fix(files): correct translations keys#348

Merged
drav0011 merged 1 commit intoBedrockTweaks:develfrom
SquatchHunter:rp/utility/hunger_preview
Oct 20, 2024
Merged

fix(files): correct translations keys#348
drav0011 merged 1 commit intoBedrockTweaks:develfrom
SquatchHunter:rp/utility/hunger_preview

Conversation

@SquatchHunter
Copy link
Copy Markdown
Member

@SquatchHunter SquatchHunter commented Sep 27, 2024

resolves: #347

  • corrected Cooked Beef to Steak
  • corrected Melon to Melon Slice
  • correct Enchanted Apple to Enchanted Golden Apple

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

* corrected Cooked Beef to Steak
* corrected Melon to Melon Slice
* correct Enchanted Apple to Enchanted Golden Apple
Copy link
Copy Markdown
Member

@PAPISOP PAPISOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it for hunger preview and music disc redstone level preview combinations too

Copy link
Copy Markdown
Member

@PAPISOP PAPISOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it for other languages too as in those languages the translations are updated with updated names

@PAPISOP
Copy link
Copy Markdown
Member

PAPISOP commented Sep 27, 2024

also update pr title to include pack name so that it looks nicer and clearer in the changelogs

Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit 3deda12 into BedrockTweaks:devel Oct 20, 2024
@drav0011
Copy link
Copy Markdown
Member

The things in the comments above are worth considering

I accepted the PR because of the following

  • With new combinations changes the lang files from the combinations will be removed
  • The best would be to consider other languages, but english is the priority
  • The PR title name should have the name but will not hold a pr just for the naming

@SquatchHunter SquatchHunter deleted the rp/utility/hunger_preview branch December 4, 2024 11:44
drav0011 added a commit that referenced this pull request Aug 8, 2025
fix(files): correct translations keys

Former-commit-id: 3deda12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UTILITY] Hunger Preview

3 participants