Skip to content

fix(files): Fix Menu Panoramas packs having a weird image in the middle#352

Merged
drav0011 merged 2 commits intoBedrockTweaks:develfrom
PAPISOP:fix/menu_panoramas
Oct 20, 2024
Merged

fix(files): Fix Menu Panoramas packs having a weird image in the middle#352
drav0011 merged 2 commits intoBedrockTweaks:develfrom
PAPISOP:fix/menu_panoramas

Conversation

@PAPISOP
Copy link
Copy Markdown
Member

@PAPISOP PAPISOP commented Oct 2, 2024

  1. Fixed the size of panorama_overlay_image to be "fill"
  2. Removed "alpha" key because it's the default value

I have merged all the commits from #302 into this pr to avoid merge conflicts so, first review that pr then review this pr

Resolves #299

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

1. Fixed the size of `panorama_overlay_image` to be "fill"
2. Removed "alpha" key because it's the default value
@PAPISOP PAPISOP force-pushed the fix/menu_panoramas branch from 4fb777c to 6715166 Compare October 2, 2024 05:52
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit c7aee79 into BedrockTweaks:devel Oct 20, 2024
@PAPISOP PAPISOP deleted the fix/menu_panoramas branch October 25, 2024 13:45
drav0011 added a commit that referenced this pull request Aug 8, 2025
fix(files): Fix Menu Panoramas packs having a weird image in the middle

Former-commit-id: c7aee79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI/Menu Panoramas] Many Packs

2 participants