Skip to content

feat(files): Added Trial Chamber Panorama#415

Merged
drav0011 merged 3 commits intoBedrockTweaks:develfrom
NSPC911:feat/more-panoramas
Dec 11, 2024
Merged

feat(files): Added Trial Chamber Panorama#415
drav0011 merged 3 commits intoBedrockTweaks:develfrom
NSPC911:feat/more-panoramas

Conversation

@NSPC911
Copy link
Copy Markdown
Contributor

@NSPC911 NSPC911 commented Dec 4, 2024

Added Trial Chamber Panorama
If you (@drav0011) wants, I can also add Pale Garden Panorama

Issues Resolved:

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

its been so long and Im working on a phone, dont mind if anything is
wrong
force-push from 30bfa4c: fixed typo
Comment thread resource_packs/packs.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanilla Tweaks now include a "version from" in their descriptions
"description": "Replaces the default Minecraft menu panorama with a 360° view of a Trial Chamber! (from 1.21)",

Copy link
Copy Markdown
Contributor Author

@NSPC911 NSPC911 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify sub version like 1.21.40 or just 1.21?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they dont have stubs so I wouldn't - probably a personal preference / DrAv question.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add subversion for the panoramas which are from a subversion
Example
<Update 1.21 panorama idk what it was> (1.21)
<Update 1.21.40 panorama pale oak and stuff> (1.21.40)

And talking about pale oak I would add once the next update releases no point now as is the default one
Can add a draft pr if you want and keep it there

@SquatchHunter
Copy link
Copy Markdown
Member

this also resolves: #416

@NSPC911 NSPC911 mentioned this pull request Dec 4, 2024
20 tasks
@NSPC911 NSPC911 requested a review from SquatchHunter December 4, 2024 12:54
Copy link
Copy Markdown
Member

@SquatchHunter SquatchHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Copy Markdown
Member

@PAPISOP PAPISOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit 409deaa into BedrockTweaks:devel Dec 11, 2024
drav0011 added a commit that referenced this pull request Aug 8, 2025
feat(files): Added Trial Chamber Panorama

Former-commit-id: 409deaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI/Panorama] Trial Chamber Panorama

4 participants