Skip to content

feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json#89

Merged
drav0011 merged 10 commits intoBedrockTweaks:develfrom
NSPC911:feat(files)-aesthetic-+-fix(files)-packs.json
Jun 25, 2024
Merged

feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json#89
drav0011 merged 10 commits intoBedrockTweaks:develfrom
NSPC911:feat(files)-aesthetic-+-fix(files)-packs.json

Conversation

@NSPC911
Copy link
Copy Markdown
Contributor

@NSPC911 NSPC911 commented Jun 19, 2024

Packs Added:

  • Accurate Scaffolding
  • Consistent Bamboo Planks
  • Allay Elytra

Combinations Added:

  • Accurate Scaffolding and Unobtrusive Scaffolding

Unofficial Issues Fixed:

  • Added missing comma at line 1070
  • Renamed all occurrences of "pack_name" to "name"

Official Issues Fixed:

By checking the following boxes with an X, you ensure that:

  • The pack was tested in-game in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

NSPC911 added 2 commits June 19, 2024 17:34
4 Packs:
Accurate Scaffolding
Consistent Bamboo Planks
Allay Elytra
Fencier Fences

1 Combination:
Accurate Scaffolding and Unobtrusive Scaffolding
Fix for the previous pull request that may or may not have caused issues._.
@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 19, 2024

Branch name was fixed according to CONTRIBUTING.md

There are two things done in the PR, so the branch name had to be unnecessarily long

Comment thread resource_packs/files/aesthetic/fencier_fences/textures/terrain_texture.json Outdated
@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 21, 2024

Okay, so I'm not sure why it still shows this
image
even though I resolved it

@NSPC911 NSPC911 requested a review from drav0011 June 21, 2024 14:35
Comment thread resource_packs/files/aesthetic/fencier_fences/textures/blocks/big_oak_fence.png Outdated
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small detail left

Comment thread resource_packs/packs.json Outdated
@drav0011
Copy link
Copy Markdown
Member

Also
image
Dark oak fence seems to not be working

@drav0011
Copy link
Copy Markdown
Member

Fence textures do not seem to match vanilla tweaks
image
image

@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 22, 2024

mb, ill move the plank texture by a bit, and fix the dark oak fence

@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 23, 2024

screenshot

Fixed the fences, but not sure how to on the gates

isotropic view of oak fence
isotropic view

i just found out how terrible i am at texturing
@NSPC911 NSPC911 requested a review from drav0011 June 23, 2024 13:13
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from those 2 small notes, the fence gates are not looking the same
The most important difference is the smootheness of the texture, you can note in bedrock it has artifacts (random dark spots, vertical lines, large color changes)

Here are reference images in case you are not able to load a java instance

Java
image
image
Bedrock
image
image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

Comment thread resource_packs/packs.json
"pack_name": "Cherry Grove",
"name": "Cherry Grove",
"pack_description": "Replaces the default Minecraft menu panorama with a 360° view of a Cherry Grove"
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noted about pack_description, should be description

@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 23, 2024

Apart from those 2 small notes, the fence gates are not looking the same
The most important difference is the smootheness of the texture, you can note in bedrock it has artifacts (random dark spots, vertical lines, large color changes)

so i just remove the darkspots of the fence and what about the fence gates? whats the issue with them?

@NSPC911
Copy link
Copy Markdown
Contributor Author

NSPC911 commented Jun 24, 2024

Refer to drav.dev>general for more info on the fence issue

@NSPC911 NSPC911 requested a review from drav0011 June 25, 2024 00:36
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit 70fe3fc into BedrockTweaks:devel Jun 25, 2024
drav0011 pushed a commit that referenced this pull request Aug 8, 2025
drav0011 added a commit that referenced this pull request Aug 8, 2025
…)-packs.json

feat(files): All Aesthetic Packs (except More Zombies) + fix(files): formatting of packs.json

Former-commit-id: 70fe3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants