Skip to content

feat(files): music_disc_redstone_levels#96

Merged
drav0011 merged 4 commits intoBedrockTweaks:develfrom
SquatchHunter:utility/music_disc_levels
Jun 24, 2024
Merged

feat(files): music_disc_redstone_levels#96
drav0011 merged 4 commits intoBedrockTweaks:develfrom
SquatchHunter:utility/music_disc_levels

Conversation

@SquatchHunter
Copy link
Copy Markdown
Member

Gives all Music Discs a redstone power level indicator in the tooltip.
Addresses: #36
By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

image

Gives all Music Discs a redstone power level indicator in the tooltip.
Comment thread resource_packs/packs.json Outdated
updated hunger preview glyph, update music_disk_redstone_levels glyph, add combination glyph, add additional english languages, updated packs.json
@SquatchHunter SquatchHunter requested a review from drav0011 June 23, 2024 09:07
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combination pack is incorrect
It should be the same as a standalone pack, when 2 packs are combined, those packs are not added to the mcpack, instead the combination is added

So this actual combination is missing the text files and the image should be in the font directory

@SquatchHunter SquatchHunter requested a review from drav0011 June 24, 2024 05:22
Copy link
Copy Markdown
Member

@drav0011 drav0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drav0011 drav0011 merged commit 9c7c340 into BedrockTweaks:devel Jun 24, 2024
@SquatchHunter SquatchHunter deleted the utility/music_disc_levels branch June 25, 2024 10:27
drav0011 added a commit that referenced this pull request Aug 8, 2025
feat(files): music_disc_redstone_levels

Former-commit-id: 9c7c340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants