Puts the Fist of Sol back in the bag.#2017
Merged
Bokkiewokkie merged 9 commits intoBeeStation:masterfrom Oct 3, 2022
QAI-07:fist-deleteus
Merged
Puts the Fist of Sol back in the bag.#2017Bokkiewokkie merged 9 commits intoBeeStation:masterfrom QAI-07:fist-deleteus
Bokkiewokkie merged 9 commits intoBeeStation:masterfrom
QAI-07:fist-deleteus
Conversation
This should, in theory, stop it from spawning in places that just ask for any syndicate vessel.
It should still be spannable by admins while not appearing under any natural circumstances, as it was intended from the start.
Contributor
Bokkiewokkie
left a comment
Bokkiewokkie
left a comment
There was a problem hiding this comment.
just a small thing...
Bokkiewokkie
added
Fix
Overmap
DeltaFire15
previously requested changes
Aug 16, 2022
Contributor
DeltaFire15
left a comment
DeltaFire15
left a comment
There was a problem hiding this comment.
Instead of changing its type away from ../syndicate/ai which leads to issues with things that check for this subtype, add it to the enemy_blacklist in ../subsystem/starsystem.dm.
Contributor
|
|
Contributor
|
ok, correction, does work, however the same issue happens to sol's revenge, might be an idea to fix it as well? |
Contributor
|
|
Contributor
|
Contributor
|
@QAI-07 Are you going to adress DeltaFire's requested changes? |
Contributor
Author
|
@Bokkiewokkie I would if I had even the slightest idea of how to do any of that. So i'm just gonna start guessing until the code complies and assume it works. |
I put it in the goddamn blacklist go away
Bokkiewokkie
requested changes
Oct 1, 2022
Remove Kebab: Commits suggestions by Bokkiewokkie Co-authored-by: Bokkiewokkie <43698041+Bokkiewokkie@users.noreply.github.com>
Bokkiewokkie
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
For a while now, on rare occasions, the Fist of Sol would appear in the Rubicon sector along with an identical clone of itself. While it still works as intended, it's appearance outside of strict admin intervention was not intended. I've just finally gotten up to fix it.
Why It's Good For The Game
Fix man good.
Also, I can now buff it without worry of it appearing randomly and jumpscaring the crew with funky new weapons.
Changelog
🆑
fix: fixed the Fist of Sol Boss showing up when it shouldn't.
/:cl: