-
-
Notifications
You must be signed in to change notification settings - Fork 266
Some projectile relaying & impact tweaks #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also makes relayed projectiles respect impact angles. namely, the angle of the projectile itself is taken into account (reads: flying into a projectile going left while facing north causes relaying on the right side, not front.)
changes projectiles to decide armor quadrant they hit by their own angle instead of relative angle; should feel more accurate on average.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
Woo, no more conflicting with myself! |
Bokkiewokkie
reviewed
Jan 3, 2026
| var/startside = pick(GLOB.cardinals) | ||
| var/turf/pickedstart = spaceDebrisStartLoc(startside, theZ) | ||
|
|
||
| var/effective_angle = (720 + original_proj_angle - angle) % 360 //Don't ask, I don't trust angles to be positive anymore. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make a proc for this at some point there are so many of these in the code
Bokkiewokkie
approved these changes
Jan 3, 2026
ss13-beebot
added a commit
that referenced
this pull request
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Have you ever wondered why that one chair on the Atlas bridge seems to get punctured by railguns far more often than other places?
Well, relayed projectiles aren't actually fully random but tend to always target the exact z center.
This makes certain locations in the exact center quite hazardous vs. piercing projectiles.
This PR changes that, by adding a degree of randomness (+- 20° angle) to relayed projectiles, making them not target the exact center tile, only center-ish.
In addition because I wanted to do it since a while, relayed projectiles now determine the side of the ship they hit from depending on their angle when hitting the ship. I've thought a while about how to best determine the side and this feels like the most consistent, with our somewhat wacky physics.
Also moves the projectile quadrant impact calculations to use that same logic because it should feel more consistent.
Why It's Good For The Game
Less getting porcupined because your chair was in the wrong place, more being able to yell at bridge if the side you really don't want hit keeps being exposed.
Testing Photographs and Procedure
Fairly tested; Though probably something to gauge the feels of.
Changelog
🆑
tweak: Relayed projectiles now have a higher degree of targeting randomness.
tweak: Relayed projectile starting sides are now determined by the angle of the original projectile.
tweak: Projectile impact quadrants are now determined by projectile facing rather than relative position to ship (hopefully feels more accurate).
/:cl: