This repository was archived by the owner on Mar 25, 2026. It is now read-only.
Merged
Conversation
Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
- Removed test mode environment variable from main.go to streamline server startup during tests. - Updated main_test.go to include a new test for the 'serve --help' command without starting the server. - Enhanced cron_test.go and http_test.go to utilize new handler creation for testing without actual server startup. These changes improve the testing framework and ensure better isolation of tests from server operations. Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
There was a problem hiding this comment.
Bug: Error Handling Masks Specific Exceptions
The error handling logic for StartRun is flawed. The if err.Error() != "" check, performed after confirming err != nil, is redundant and incorrect because a non-nil error's Error() method always returns a non-empty string in Go. This masks the true intention of ignoring specific errors (e.g., from duplicate detection) and causes all non-nil errors to be added to the errors list.
core/cron.go#L640-L645
core/cron.go#L222-L226
Lines 222 to 226 in 17cc657
- Introduced unit tests for `generateDeterministicRunID` to ensure consistent UUID generation for identical inputs and different UUIDs for varying inputs. - Verified UUID generation with reordered map keys and complex nested structures. - Added a time window test to confirm UUIDs remain consistent within a 5-minute interval. These changes enhance the reliability of UUID generation in the engine, ensuring proper deduplication of runs with identical inputs. Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
- Introduced a new test, `TestCron_ErrorHandling`, to validate the behavior of cron workflows when encountering errors, specifically when a required step is missing. - The test creates a temporary workflow that is designed to fail and checks that the appropriate error messages are returned in the response. - Updated error handling in `CheckAndExecuteCronFlows` to ensure that all errors are captured and reported correctly. These changes enhance the robustness of cron workflow error handling and improve test coverage. Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
…reness - Replaced the default HTTP client with a context-aware client in `http_adapter.go` to allow proper context cancellation and deadline handling. - Updated `ListServers` method in `remote.go` to use a context-aware HTTP client, ensuring that context deadlines take precedence over client timeouts. - Modified database operations in `postgres.go` and `sqlite.go` to use context-aware execution methods, enhancing the responsiveness and reliability of database interactions. These changes improve the overall handling of context in HTTP requests and database operations, leading to better resource management and error handling. Signed-off-by: Alec M. Wantoch <alec@wantoch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serverless wayyyy to much of a PITA for now. Killing it for awhile.