Conversation
|
I've tested this on a CV thing, but not on a VCMC (as I don't have one), and seems to work as expected. One small issue I need to figure out that is that occasionally I needed to panic the midi after changing the octave/semitone value. The NoteOff messages may not taking into account the transposition if I've got a sequence running whilst I change the parameter so I'll need to poke around to suss that out. I'm still finding my way around the codebase, but I assume that will be a fairly easy fix. |
|
Haven't seen the note sticking thing again. @xustafu @SergioRetamero - are you able to review this PR when you get a moment? |
|
Sorry for the delayed answer!!! hope to be testing this one on monday. In the meantime, and for organization purposes, do you mind doing the request to be merged to Transpose branch? |
|
Awesome, thanks @xustafu Updated the base to be the Transpose branch on origin. Let me know how you go 😁 |
Fixes #12
TRANSPOSEsub-menu toFUNCTIONmenu on analogue inputs