[PHP-Config] Update main configuration#192
Conversation
a16b034 to
9087da1
Compare
|
@acoulton @carlos-granados I'm wondering if it would be interesting to add this PHPUnit file in the Behat codebase. WDYT? |
9087da1 to
8356b57
Compare
f1c4ed2 to
596ac49
Compare
carlos-granados
left a comment
There was a problem hiding this comment.
Looking good, just a small comment
| return new Config() | ||
| ->withProfile( | ||
| new Profile('default') | ||
| ) |
There was a problem hiding this comment.
In the previous example there was a line with #... indicating where you would add additional configuration, maybe we could do the same here with a //... line after the new Profile line
596ac49 to
6a6ab53
Compare
| >withExtension( | ||
| new Extension('Behat\MinkExtension', [ | ||
| 'base_url' => 'http://www.example.com', | ||
| 'selenium2' => '~', |
There was a problem hiding this comment.
Actually, shouldn't this be null rather than the '~' string?
There was a problem hiding this comment.
it should. An unquoted ~ in Yaml is a null value.
There was a problem hiding this comment.
Yes, I think so too. I'm gonna change that.
It wouldn't hurt to add more unit test coverage for the php config, but this looks like it overlaps a bit with some of the tests that are already there at https://github.com/Behat/Behat/tree/master/tests/Behat/Tests/Config ? Unless I'm misunderstanding? |
6a6ab53 to
08ec8a3
Compare
Related to #184
I've tested my examples with that PHPUnit file.