Solve segfaults caused by expanding / refreshing invalid subtrees #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves segfaults from #52 and #111
One problem was caused by attempting to expand invalid subtrees, e.g., with an unconnected node. This change gives a popup message saying that this subtree can not be expanded.
Another problem was when a subtree was already expanded, and then modified into an invalid subtree, e.g., by removing an edge. Switching back to the tab with the expanded subtree triggered code to refresh the now invalid subtree leading to a segfault. This change collapses the subtree before refreshing it.