VoteStreaks: support exact milestone streak rewards and migration from legacy VoteStreak data

[semisolar]

Is your feature request related to a problem? Please describe.
We are looking at migrating from the legacy VoteStreak.Day setup to the newer VoteStreaks system, but the new system does not seem to support our current streak reward structure.

Our current rewards are exact milestone based, not interval based. For example, we reward players at daily streaks like 3, 5, 7, 14, 21, 28, 42, 56, 70, etc. Each milestone can have a different reward file, and later streaks usually give better/different rewards.

From what I can tell, VoteStreaks.Requirements.Amount works more like “every X successful periods.” So Amount: 7 would reward at 7, 14, 21, 28, etc. That is useful, but it does not replace exact milestone rewards where day 7, 14, and 21 each need different rewards.

We also have players with daily streaks in the hundreds, so resetting streaks during migration would be a major issue.

Describe the solution you'd like
It would be helpful if the new VoteStreaks system supported exact milestone rewards, possibly with an exact/interval mode.

Example idea:

VoteStreaks:
  Daily_14:
    Type: DAILY
    Mode: EXACT
    Requirements:
      Amount: 14
      VotesRequired: 1
    Rewards:
    - VoteSteak_14_Rewards_Online
    - VoteSteak_14_Rewards_Offline

A safe migration path from legacy active streak data would also be helpful, especially from fields like DayVoteStreak and DayVoteStreakLastUpdate.

We would want to migrate active/current streaks, not each player’s best historical streak. For example, if a player currently has DayVoteStreak: 168 and their DayVoteStreakLastUpdate shows the streak is still active, the new VoteStreaks state should continue from 168 rather than starting at 0.

Ideally this would:

• preserve existing active player streak counts
• use the legacy last-update timestamp to avoid migrating stale streaks
• allow missed-day leniency from the new system
• support different reward files at exact streak milestones
• avoid re-granting old milestones players already passed

Describe alternatives you've considered
For now we are planning to keep the legacy VoteStreak.Day setup because it preserves current player streaks and supports our exact milestone reward structure.

We considered using VoteStreaks.Requirements.Amount, but interval rewards do not fit our setup because each milestone can have different rewards.

Additional context
Our server has long-running vote streaks, including players with streaks in the hundreds of days. The newer missed-day leniency system is useful, but we cannot migrate if it means losing existing streaks or changing milestone rewards into repeated interval rewards.

[BenCodez]

A migration system is something I plan to add eventually, but I wanted to make sure the newer votestreaks worked as they should before making them more complicated.

It's just votestreaks your having problems with and not milestones right?

[semisolar]

A migration system is something I plan to add eventually, but I wanted to make sure the newer votestreaks worked as they should before making them more complicated.

It's just votestreaks your having problems with and not milestones right?

Yes everything else has been working for us post-update. We have fully migrated to the new VoteMilestones system and the new VoteReminders system, and both have been working without issue.

The only blocker for us right now is VoteStreaks. Once milestone-type streaks are available, ideally with a safe migration path from the legacy active streak data, I do plan on migrating to that as well.

[BenCodez]

So you just needed a migration and a way to prevent votestreaks from repeating?

[semisolar]

So you just needed a migration and a way to prevent votestreaks from repeating?

Yes, that's basically it.

We need:

1. A migration path from the legacy active daily streak data, so existing player streaks do not reset.

2. A non-repeating / exact milestone mode for VoteStreaks.

For example, day 3, day 5, day 14, and day 30 should each be able to have different rewards, and each should only trigger once when the player reaches that exact streak

[BenCodez]

I'll look at trying to do this later today/tomorrow.

[semisolar]

Sounds good, thank you. I held off on trying a PR since VoteStreaks is still new in 7.0 and I wasn’t sure what direction you wanted to take it, but I’m happy to test it on our setup once there’s something available.

[BenCodez]

https://bencodez.com/job/VotingPlugin/

a74a7e3

Run /av migratevotestreaks

should take care of everything, did some testing already and it seemed to work fine. Create backups before using though.

[semisolar]

Thanks again for adding the migration command. I opened a small PR that builds on it and covers the two cases affecting our setup:

• Recurring: false now treats the streak as an exact one-time reward instead of repeating at every multiple.
• legacy list-based reward references are preserved during migration.

PR: 1509

[BenCodez]

merged, thanks

[semisolar]

Closing this as complete now.

I have not tested this on our production server yet. However, I have tested it in my staging environment which has it working correctly. Production is just waiting until our next maintenance period.