Fix spurious defaultRank warnings for PVP setting flags

The minimumRank validation was clamping SETTING flags that use -1
(disabled) as their defaultRank. Since -1 is a valid disabled state
for SETTING/WORLD_SETTING flags (Island.isAllowed checks >= 0),
restrict the validation to PROTECTION flags only.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tastybento

src/main/java/world/bentobox/bentobox/api/flags/Flag.java

@@ -797,8 +797,10 @@ public Builder hideWhen(HideWhen hideWhen) {
          * @return Flag
          */
         public Flag build() {
-            // Ensure the default rank is not below the minimum selectable rank
-            if (defaultRank < minimumRank) {
+            // Ensure the default rank is not below the minimum selectable rank.
+            // Only applies to PROTECTION flags — SETTING/WORLD_SETTING flags use -1
+            // as a valid "disabled" state (Island.isAllowed checks >= 0).
+            if (type == Type.PROTECTION && defaultRank < minimumRank) {
                 BentoBox.getInstance().logWarning("Flag " + id + " defaultRank (" + defaultRank
                         + ") is below minimumRank (" + minimumRank + "); raising defaultRank to minimumRank.");
                 defaultRank = minimumRank;

src/test/java/world/bentobox/bentobox/api/flags/FlagTest.java

@@ -450,4 +450,17 @@ void testDefaultRankClampedToMinimumRank() {
                 .build();
         assertEquals(RanksManager.MEMBER_RANK, flag.getDefaultRank());
     }
+
+    /**
+     * SETTING flags should allow -1 (disabled) as defaultRank without clamping,
+     * since Island.isAllowed() uses >= 0 as the enabled threshold.
+     */
+    @Test
+    void testSettingFlagAllowsNegativeDefaultRank() {
+        Flag flag = new Flag.Builder("pvp_test", Material.ARROW)
+                .type(Flag.Type.SETTING)
+                .defaultRank(-1)
+                .build();
+        assertEquals(-1, flag.getDefaultRank());
+    }
 }