Add tests for inGameWorld() vanilla nether/end early-return paths#165
Merged
tastybento merged 2 commits intodevelopfrom Mar 8, 2026
Merged
Add tests for inGameWorld() vanilla nether/end early-return paths#165tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
Merged
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on PR #164 for Release 4.8.1
Add tests for inGameWorld() vanilla nether/end early-return paths
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Border.inGameWorld()gained two early-returnfalsepaths for vanilla (non-island) nether and end worlds, butBorderTesthad no coverage for them.Added tests
testInGameWorldReturnsFalseForVanillaNether—NETHER+isIslandNether=false→falsetestInGameWorldReturnsFalseForVanillaEnd—THE_END+isIslandEnd=false→falsetestInGameWorldDelegatesToGameModeForIslandNether—NETHER+isIslandNether=true→ falls through to game mode checktestInGameWorldDelegatesToGameModeForIslandEnd—THE_END+isIslandEnd=true→ falls through to game mode checkEach test stubs
world.getEnvironment()and the relevant IWM predicate directly on the existingworld/iwmmocks fromCommonTestSetup.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.