Fix vanilla nether/end tests to correctly exercise early-return path in onPlayerLeaveIsland#166
Merged
tastybento merged 3 commits intodevelopfrom Mar 8, 2026
Merged
Conversation
Merged
…return for vanilla worlds Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from PR #164 for Release 4.8.1
Fix vanilla nether/end tests to correctly exercise early-return path in onPlayerLeaveIsland
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testOnPlayerLeaveIslandVanillaNetherandtestOnPlayerLeaveIslandVanillaEndclaimed to verify that movement in vanilla (non-island) worlds is ignored, but both assertedassertTrue(event.isCancelled())— the opposite behavior. Sinceaddon.inGameWorldwas never overridden from the defaulttrue, the guard at line 292 never triggered and the tests were silently exercising the teleport-back path instead.Changes
iwm.isIslandNether/End+island.onIslandstubs withwhen(addon.inGameWorld(any())).thenReturn(false)and assertverify(addon, never()).getIslands()— consistent with the existingtestOnPlayerLeaveIslandReturnTeleportOutsideCheckNotInGameWorld"did not found"→"did not find")💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.