Conversation
Agent-Logs-Url: https://github.com/BentoBoxWorld/Border/sessions/9e46c1d4-f327-4ee5-aa11-cb855d8ddb11 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…guage-translation Update Russian locale to MiniMessage format
paper-api is a -SNAPSHOT artifact but the papermc repo had snapshots disabled, so Maven skipped it and failed to resolve the dependency on clean CI builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Release-oriented update for the Border addon, primarily adjusting versioning and localization assets for 4.8.3.
Changes:
- Bumped Maven
build.versionto4.8.3. - Updated Russian locale strings and added
border.set-colormessages. - Removed the legacy/incorrectly-named
zh_CN.ymllocale file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/resources/locales/zh_CN.yml | Removed a locale file (appears to be a legacy/incorrect locale filename). |
| src/main/resources/locales/ru.yml | Updated RU translations and added set-color keys; changed message formatting style. |
| pom.xml | Version bump to 4.8.3; enabled snapshots for the PaperMC repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@tastybento I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly. You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch. |
|
@copilot Make a PR to convert all the locale files to use MiniMessage formating and to shift the BentoBox requirement to 3.12.0 and also place that API requirement in addon.yml as well. |
|
@tastybento I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly. You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch. |
|
@copilot Create a new PR to the develop branch that converts all the locale files to use MiniMessage formatting and to shift the BentoBox requirement to 3.12.0 and also place that API requirement in addon.yml as well. |
|
@tastybento I've opened a new pull request, #173, to work on those changes. Once the pull request is ready, I'll request review from you. |
…o 3.12.0 Agent-Logs-Url: https://github.com/BentoBoxWorld/Border/sessions/85710e8c-6812-47fd-b405-a5b93bde2269 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…le files Agent-Logs-Url: https://github.com/BentoBoxWorld/Border/sessions/85710e8c-6812-47fd-b405-a5b93bde2269 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Convert all locale files to MiniMessage format and bump BentoBox requirement to 3.12.0
Add set-color.description, set-color.changed, set-color.error-invalid-color to all 20 non-Russian locales. Fix uk.yml MiniMessage tag positioning so the entire phrase is wrapped, and correct pl.yml [typ] placeholder to [type] so substitution works. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the preferred order for finding dependency source (local Maven repo, sibling Git clones under ~/git/, only then the network), catalogue the BentoBox ecosystem repos checked out as siblings, and bump the stated BentoBox target to 3.12+ to match pom.xml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clears all 140 open issues reported on SonarCloud: - Strip `public` modifier from JUnit 5 test classes and annotated methods (S5786, 118 issues) via a targeted perl sweep; setUp/tearDown promoted to `protected` to preserve cross-package inheritance. - PlayerListener: - Remove unused BentoBox import (S1128) - Collapse nested if in onEntityMount (S1066) - Guard @nonnull getIslandAt() calls in onItemDrop/onPlayerDeath (S2637) - Extract backtrack logic from onPlayerLeaveIsland into backtrackToIsland/safeLandingMaterial to drop cognitive complexity from 17 to below the 15 limit (S3776) - TestWorldSettings: annotate empty setDifficulty stub (S1186) - PlayerListenerTest: merge three identical "not in game world" tests into one (S5976/S4144); replace deprecated PlayerJoinEvent/PlayerQuitEvent String constructors with the Adventure Component ones (S5738) - CommonTestSetup: drop unused `throws Exception` on setUp (S1130), remove commented-out translateColorCodes stub (S125), suppress deprecation on FixedMetadataValue (S1874), delete unused getPlayerDeathEvent helper that used a @deprecated(forRemoval) ctor (S5738) - PerPlayerBorderProxyTest: drop unused `throws Exception` (S1130) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Wrap @nonnull getLocation() sites in PlayerListener with Objects.requireNonNull - Reduce cognitive complexity of ShowBarrier.showWalls and showPlayer by extracting showWallAlongZ/showWallAlongX/renderBorderBlock/spawnBorderParticle - Strip unused ItemStack import from CommonTestSetup - Drop unnecessary protected on lifecycle methods in standalone test classes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No description provided.