Release 1.6.0#394
Merged
Merged
Conversation
Drop Spigot + PowerMock + JUnit 4 in favor of Paper API, Mockito mockStatic, and MockBukkit, matching the BSkyBlock blueprint. Source fallout for Paper's Adventure-based AdvancementDisplay is handled via PlainTextComponentSerializer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a language cycle button to the web library GUI that defaults to the user's locale, and word-wraps each entry's description at 22 characters so the tooltip is no longer absurdly wide. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, clicking the admin panel's web library button before the GitHub catalog finished downloading surfaced a "no library entries" chat error. The button now renders as a barrier with a "Library download requested..." lore while the catalog is empty, kicks off an early async download on first render, and swaps in place to the cobweb icon once entries are available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Skip entries with missing fields instead of throwing NPE, and log a warning with the raw JSON and the missing field name so the weblink repo maintainer can identify and fix the bad entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces all Bukkit &x color/format codes with their MiniMessage tag equivalents across all 15 locale files. The artifactual space that the old renderer auto-stripped after each &x code is also removed, with spacing placed logically around words and placeholders. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Long reward descriptions no longer overflow the tooltip width. wrapToWidth() measures visible length by stripping MiniMessage tags and legacy colour codes before wrapping, so formatting is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…overage Extract common BentoBox/MockBukkit/Mockito boilerplate into a reusable abstract base class. Rewrite TryToCompleteTest to extend it and add 30 new tests covering OTHER_TYPE, STATISTIC_TYPE, timeout, rewards, and level completion flows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…flows Tests YAML import (file not found, success, no game mode, null user), JSON file import (null world, not found, wipe existing, with challenges), JSON string download (null world, existing data, success, empty, multiple), and JSON export (already exists, success, empty data, console, prefix stripping). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Expand ChallengesManagerTest with 34 tests covering getStatisticData (player-only and island aggregation), isBreachingTimeOut, getLastCompletionDate, level queries, and challenge/level count metrics. Add admin command test suite with shared AdminCommandTestBase and tests for all 6 admin commands: ChallengesAdminCommand, CompleteCommand, ResetCommand, ReloadChallenges, MigrateCommand, and ShowChallenges. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add ~60 new constants to Constants.java covering GUI keys, tip keys, conversation keys, parameter placeholders, error keys, panel suffixes, handler keys, and import manager keys. Update 21 source files to use the constants instead of duplicated string literals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Surefire's hardcoded <argLine> with --add-opens flags was overriding
JaCoCo's argLine property, preventing the agent from attaching to the
test JVM. Add @{argLine} late-binding reference so both the JaCoCo
agent and --add-opens flags are passed to the forked test process.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests cover CommonPanel, CommonPagedPanel, ConversationUtils, AdminPanel, ListChallengesPanel, GameModePanel, and MultiplePanel. Uses reflection-based setup to coexist with existing PowerMock JUnit 4 tests. Adds JUnit 5, mockito-junit-jupiter, and vintage engine dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace Challenge.clone() with copy() factory method (S2975) - Add assertions to testMigrateDatabase, testSave, testGetLatestUnlockedLevelSingleLevel, and testTabCompleteUserStringListOfStringNoArgs (S2699) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ockBukkit Replace PowerMock with Mockito 5.11.0 mockStatic and MockBukkit for server infrastructure. Upgrade to Paper API 1.21.11 and BentoBox 3.14.0. Port all 8 JUnit 4 test files to JUnit 5, add WhiteBox and AbstractChallengesTest utilities, and update panel tests to use MockBukkit lifecycle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Worktree junit5 panel tests
…786) JUnit 5 tests do not require public visibility. Removes public from all top-level test class declarations and @Test/@BeforeEach/@AfterEach method signatures across 7 panel test files (98 changes total). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n declaration for improved clarity
…eners Adds 106 new tests across 9 classes covering previously untested areas: - ChallengeEventsTest: all 4 event POJOs (constructors, setters, handlers) - ChallengesPlayerDataTest: completion tracking, timestamps, reset, levels, history, equals/hashCode - 5 request handler tests: input validation, unknown-world/challenge cases, valid responses - ResetListenerTest: all 5 event handlers x enabled/disabled/island-data config combinations - SaveListenerTest: kick and quit both flush the player cache Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.