When the player performs skyblock operations while in a non-BentoBox world, their inventory will be cleared.

[keimuji]

Expected behavior

When the player is in a non-BentoBox world and performs certain operations with the BentoBox plugin, their inventory in the non-BentoBox world should not be affected.

Observed/Actual behavior

When the player is in a non-BentoBox world and performs certain operations with the BentoBox plugin, their inventory in the non-BentoBox world gets cleared.

Steps/models to reproduce

Take BSkyBlock as an example:

1.Player B creates a BSkyBlock island and invites Player A.

2.Player A accepts the invitation and is automatically teleported to the island created by Player B.

3.Player A teleports to a non-BentoBox world.

4.Player B executes /is team kick Player A.

5.At this point, Player A's inventory disappears.

Another scenario:

1.A player creates a BSkyBlock island and is automatically teleported to the island.

2.The player teleports from the island to a non-BentoBox world.

3.The player executes /is reset to reset their island.

4.After the reset is complete, the player is automatically teleported back to the BentoBox world.

5.The player then returns to the non-BentoBox world. At this point, the player's inventory disappears.

I’ve only listed two scenarios, but there are actually other combinations.

For example, if player A has joined player B’s island, and while player A is in a non-BentoBox world, player B resets their own island, this also causes player A’s inventory in the non-BentoBox world to be cleared.

I’m not sure if there are any other overlooked scenarios.

BSkyBlock configuration:
~\plugins\BentoBox\addons\BSkyBlock\config.yml

on-join:
      money: true
      inventory: true
      health: true
      hunger: true
      exp: true
      ender-chest: true
on-leave:
      money: true
      inventory: true
      health: true
      hunger: true
      exp: true
      ender-chest: true

The reason for this configuration is that I do not want players to retain their previous items or progress after creating/resetting an island, being invited, or being kicked.

This configuration should only affect the BentoBox world and should not affect other worlds.

BentoBox version

https://mclo.gs/kHOKVEz

[15:16:39] [Server thread/INFO]: [BentoBox] Enabling BentoBox v3.16.2
[15:16:39] [Server thread/INFO]: [BentoBox] Loading Settings from config.yml...
[15:16:39] [Server thread/INFO]: [BentoBox] Saving default panels...
[15:16:41] [Server thread/INFO]: [BentoBox] Loading addons...
[15:16:41] [Server thread/INFO]: [BentoBox-Level] Loading server plugin BentoBox-Level v2.27.0
[15:16:41] [Server thread/INFO]: [BentoBox-BSkyBlock] Loading server plugin BentoBox-BSkyBlock v1.20.0
[15:16:41] [Server thread/INFO]: [BentoBox-AOneBlock] Loading server plugin BentoBox-AOneBlock v1.25.0
[15:16:41] [Server thread/INFO]: [BentoBox-AcidIsland] Loading server plugin BentoBox-AcidIsland v1.22.0
[15:16:41] [Server thread/INFO]: [BentoBox-InvSwitcher] Loading server plugin BentoBox-InvSwitcher v1.17.1
[15:16:41] [Server thread/INFO]: [BentoBox-Biomes] Loading server plugin BentoBox-Biomes v2.3.0
[15:16:42] [Server thread/INFO]: [BentoBox-CaveBlock] Loading server plugin BentoBox-CaveBlock v1.20.1
[15:16:42] [Server thread/INFO]: [BentoBox-Boxed] Loading server plugin BentoBox-Boxed v3.3.0
[15:16:42] [Server thread/INFO]: [BentoBox-Challenges] Loading server plugin BentoBox-Challenges v1.6.0
[15:16:43] [Server thread/INFO]: [BentoBox-StrangerRealms] Loading server plugin BentoBox-StrangerRealms v1.0.5
[15:16:43] [Server thread/INFO]: [BentoBox-Border] Loading server plugin BentoBox-Border v4.8.3
[15:16:43] [Server thread/INFO]: [BentoBox-DimensionalTrees] Loading server plugin BentoBox-DimensionalTrees v1.9.0
[15:16:43] [Server thread/INFO]: [BentoBox-Poseidon] Loading server plugin BentoBox-Poseidon v1.1.0
[15:16:43] [Server thread/INFO]: [BentoBox-ControlPanel] Loading server plugin BentoBox-ControlPanel v1.16.0
[15:16:43] [Server thread/INFO]: [BentoBox-Bank] Loading server plugin BentoBox-Bank v1.9.1

Plugin list

No response

Other

No response

[tastybento]

Yes, these are interesting cases. They are also going to take some careful planning to see how they can be prevented. Thanks.

[tastybento]

These issues come into play if the Admin is using InvSwitcher because the inventories between worlds can be kept separate, so I am moving this to InvSwitcher repo, even though some changes may be needed in BentoBox to address them. So, the assumption for all these scenarios is that InvSwitcher is being used.

Scenario 1

1. Player B creates a BSkyBlock island and invites Player A.
2. Player A accepts the invitation and is automatically teleported to the island created by Player B.
3. Player A teleports to a non-BentoBox world. Their inventory is swapped out for the other world's inventory.
4. Player B executes /is team kick Player A.
5. At this point, Player A's inventory disappears.

The fault here is that Player A is no longer in the same world as the game world, and so the inventory that they have is not the one to be cleared. Ideally, what would happen is that the request to clear inventory would be intercepted by InvSwitcher, ideally via an event and handled according to the rules that InvSwitcher knows about. Therefore we need the following from BentoBox:

• In the PlayersManager#cleanLeavingPlayer method, cancelable events fired for each of the actions with the player, world, island:
  • Removable of tamed animals (this also needs to be added to InvSwitcher)
  • EnderChest clearing
  • Inventory clearing
  • Money clearing
  • Health resetting
  • Hunger resetting
  • Exp resetting

Then we need InvSwitcher to listen for these events and do the following:

• If the player is in the same inventory world as the event, then allow it and do nothing. Note that "same inventory world" means that InvSwitcher has the same inventory for the player in both worlds.
• If the player is not in the same inventory world, then cancel the event, but then perform the clearing on the stored inventory for that inventory world, if it exists.

Let check the next scenario and see if that would cover it:

Another scenario:

1. A player creates a BSkyBlock island and is automatically teleported to the island.
2. The player teleports from the island to a non-BentoBox world.
3. The player executes /is reset to reset their island.
4. After the reset is complete, the player is automatically teleported back to the BentoBox world.
5. The player then returns to the non-BentoBox world. At this point, the player's inventory disappears.

Yes, this will correctly be handled by this approach. The PlayersManager#cleanLeavingPlayer method is called when resetting an island too.