If donate blocks are more then limit they still counts

[SirvydasS]

Expected behavior

If a player has donated 1000 iron blocks, and after time, the iron block limit changed to 500.
So now only 500 blocks count as points.

Observed/Actual behavior

Now the player has donated more than the limit blocks and all block counts to Island level.

This time I faced a problem when there was no limit of blocks if they donated.

Steps/models to reproduce

Have limit of Iron Block 1000
Donate 1000 iron blocks
Change iron blocks limit to 500.
Restart
Island level caculation still counts all 1000 blocks.

BentoBox version

[19:20:35] [Server thread/INFO]: Running PAPER 1.21.11 .
[19:20:35] [Server thread/INFO]: (1.21.11-2568-f57bd86 (MC: 1.21.11))
[19:20:35] [Server thread/INFO]: BentoBox versija: 3.16.2-SNAPSHOT-b236
[19:20:35] [Server thread/INFO]: Database: MARIADB
[19:20:35] [Server thread/INFO]: Loaded Game Worlds:
[19:20:35] [Server thread/INFO]: oneblock_world ( OneBlock ): Paviršiaus pasaulis, Neteris, Pabaiga
[19:20:35] [Server thread/INFO]: Loaded Addons:
[19:20:35] [Server thread/INFO]: AOneBlock 1.25.0-SNAPSHOT-b529 ( ENABLED )
[19:20:35] [Server thread/INFO]: Bank 1.9.1-SNAPSHOT-b142 ( ENABLED )
[19:20:35] [Server thread/INFO]: Biomes 2.3.0 ( ENABLED )
[19:20:35] [Server thread/INFO]: Border 4.8.3-SNAPSHOT-b308 ( ENABLED )
[19:20:35] [Server thread/INFO]: Challenges 1.6.0 ( ENABLED )
[19:20:35] [Server thread/INFO]: DimensionalTrees 1.9.0 ( ENABLED )
[19:20:35] [Server thread/INFO]: ExtraMobs 1.14.0 ( ENABLED )
[19:20:35] [Server thread/INFO]: FarmersDance 1.2.2-SNAPSHOT ( ENABLED )
[19:20:35] [Server thread/INFO]: Greenhouses 1.9.4-SNAPSHOT-b424 ( ENABLED )
[19:20:35] [Server thread/INFO]: Level 2.28.0-SNAPSHOT-b734 ( ENABLED )
[19:20:35] [Server thread/INFO]: Likes 2.5.0-SNAPSHOT-b147 ( ENABLED )
[19:20:35] [Server thread/INFO]: Limits 1.28.2-SNAPSHOT-b414 ( ENABLED )
[19:20:35] [Server thread/INFO]: MagicCobblestoneGenerator 2.7.2-SNAPSHOT-b334 ( ENABLED )
[19:20:35] [Server thread/INFO]: TwerkingForTrees 1.6.0-SNAPSHOT-b138 ( ENABLED )
[19:20:35] [Server thread/INFO]: Warps 1.19.0 ( ENABLED )

Plugin list

No response

Other

No response

[tastybento]

Hmm l, I could go either way on this. The player donated when the limit was higher. Why should they be penalized because you changed it later?

[SirvydasS]

I think the block limit is intended to limit how many blocks count toward the island level, so if the limit logic is updated, then the donated block limit should also change automatically, just like the normal level limit already worked before.

There can also be cases where block limit bugs were described/configured incorrectly, causing the limit to be set too high, and players abused that mistake by donating huge amounts of blocks. (It creates unfairness between players who didn’t get the chance to exploit the bug).

And of course, there can be bugs in the plugin itself (which is the situation I’m currently dealing with), where players find ways to bypass the system and donate more blocks than intended. After fixing the bug, the proper limit still doesn’t apply to them. Right now, the only option left is the inconvenient method of manually going through each player, calculating which limit they exceeded, and adjusting it accordingly.

I think there should at least be some kind of setting to enable or disable this type of limit recalculation.

Or, if this recalculation heavily impacts the overall logic/performance, then it should be possible to completely disable donate level calculations altogether.

[tastybento]

Okay. You make a good argument. Let me investigate this.