Release 2.26.0#421
Merged
tastybento merged 8 commits intomasterfrom May 4, 2026
Merged
Conversation
DonationPanel previously had a hardcoded 36-slot, 4-row layout. Move it to the standard BentoBox templated-panel pattern so admins can change rows, button positions, and icons via panels/donation_panel.yml without touching code. The panel still uses a custom listener for the drag-and-drop donation slots; only layout resolution is template-driven, with the original hardcoded layout kept as a fallback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rce-shown format Agent-Logs-Url: https://github.com/BentoBoxWorld/Level/sessions/9233b785-a13b-4ea5-9b58-18fe24bdf4e9 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- DonationPanel: use HashSet.newHashSet (S6485) and method reference for forEach (S1612). - DonationPanelLayout: replace 15-param constructor (S107) with a Builder accumulator. Extract processCell/addDecorative helpers from fromTemplate to bring cognitive complexity (S3776) and brain-method metrics (S6541) under threshold, eliminating the multi-decl warnings (S1659) and reducing in-loop continues (S135). - DonationPanelLayoutTest: use assertNotEquals instead of assertTrue with != (S5785). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…-panel feat: make donation panel size and layout configurable
Removed `public` from JUnit 5 test classes and `@Test`-annotated methods across 24 files. Lifecycle methods (`setUp`/`tearDown`) that are overridden across packages from CommonTestSetup are lowered to `protected` rather than package-private — Java forbids reducing override visibility further. Skipped LevelsManagerTest and EquationEvaluatorTest, which still use JUnit 4's `org.junit.Test` and require `public`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These two files were the last holdouts using org.junit.Test (JUnit 4). With no junit-vintage engine on the classpath, the JUnit 5 runner was silently skipping their @test methods — LevelsManagerTest reported 0 tests run for years. Changes: - Switch imports from org.junit.{Test, Assert.*} to org.junit.jupiter.api.{Test, Assertions.*}. - Apply S5786 visibility lowering consistent with the rest of the test suite (class package-private, @test methods package-private, setUp/tearDown overrides protected). - Flip assertTrue arg order on the now-active descending-order check in testGetTopTenSortOrder (JUnit 5 puts the message last). - LevelsManagerTest only: drop the redundant @mock IslandWorldManager iwm field that was shadowing CommonTestSetup's iwm — the parent already wires plugin.getIWM() to its own iwm, so configuring the shadow had no effect. - LevelsManagerTest only: stub Bukkit.getPlayer(any(UUID)) -> null so hasTopTenPerm short-circuits via the null check (RETURNS_DEEP_STUBS was returning a player whose hasPermission defaulted to false, which made the now-active rankings tests fail). Test count: 190 -> 208. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.