Fix admin GUI issues and Limits 1.28 compatibility (#68, #69, #70, #71)#72
Merged
tastybento merged 2 commits intodevelopfrom Feb 23, 2026
Merged
Fix admin GUI issues and Limits 1.28 compatibility (#68, #69, #70, #71)#72tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
- Update pom.xml to use Limits 1.28.0-SNAPSHOT - BlockLimitsUpgrade: pass block.getKey() (NamespacedKey) to IslandBlockCount instead of Material - LimitsReward: same NamespacedKey fix for BLOCK case in apply() - JoinPermCheckListener, LimitsPermCheckListener: fix EntityGroup import from world.bentobox.limits.Settings.EntityGroup → world.bentobox.limits.EntityGroup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- #71: Call saveUpgradeData() + refreshDatabaseUpgrades() when active is toggled in EditUpgradePanel; also refresh on onReload() so DB upgrades appear in the player shop without a server restart. - #69/#68: Rewrite AdminPanel as a direct list view — no intermediate Add/Edit/Delete selector screen. Upgrades are listed immediately with left-click to edit and right-click to delete (with confirmation). An 'Add upgrade' button is always visible. An empty-state item guides admins on a fresh install. AbPanel gains onBuildHook() so returning from EditUpgradePanel always shows a refreshed list. - #70 (8 UX improvements): 1. User-typed name is now the display name (not the prefixed uniqueId) for both upgrades and tiers. 2. New upgrades default to active=true. 4. Tier Edit/Delete buttons are hidden when no tiers exist; Add tier shows a hint that at least one tier is required. 5. Tier display name used in list panels instead of uniqueId. 6. 'Add new reward/price' button changed from green glass pane to Emerald for better visibility. 7. Range reward GUI shows formula value on the status icon instead of the generic 'Valid Configuration' label. 8. Range reward formula input now validates as a parseable math expression; invalid input is rejected. DatabaseUpgrade.isShowed() now also returns false when no tiers are configured, preventing the upgrade from appearing as 'maxed out'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Limits 1.28.0 compatibility
pom.xmlto Limits1.28.0-SNAPSHOTBlockLimitsUpgrade: block limit offset now usesNamespacedKey(block.getKey()) instead ofMaterialLimitsReward: same fix for the DB-backed rewardJoinPermCheckListener/LimitsPermCheckListener: updatedEntityGroupimport toworld.bentobox.limits.EntityGroup(moved from inner class)#71 — DB upgrades not appearing in player panel
EditUpgradePanel: toggling active now immediately callssaveUpgradeData()+refreshDatabaseUpgrades()UpgradesAddon.onReload(): also callsrefreshDatabaseUpgrades()DatabaseUpgrade.isShowed(): returns false when no tiers configured (prevents "maxed out" display)#69 — Admin panel opens directly in list view
AdminPanelrewritten as a direct list: no intermediate Add/Edit/Delete selector screenAbPanelgainsonBuildHook()/clearItems()/setupNavigationButton()so the list auto-refreshes on everygetBuild()call#68 — Empty admin list on fresh install
#70 — UX improvements
GameMode_inputuniqueId) for upgrades and tiersactive=trueTest plan
mvn testpasses (70 tests)/bsb admin upgrade→ list opens immediately with "No upgrades yet" message/is upgradeswithout restart🤖 Generated with Claude Code