Skip to content

Finish collective subroutine support#21

Merged
rouson merged 16 commits intomainfrom
complex-double
Feb 28, 2022
Merged

Finish collective subroutine support#21
rouson merged 16 commits intomainfrom
complex-double

Conversation

@rouson
Copy link
Copy Markdown
Collaborator

@rouson rouson commented Feb 25, 2022

With this PR, Caffeine reaches a status of no known bugs. 🎆 This PR is ready to merge if the CI tests pass and any review comments are addressed. This PR probably warrants an initial alpha release of Caffeine. Things that might be worth addressing before such a release are

  • Drafting at least a skeletal spec,
  • Setting up the CI scripts to deploy automatically generated HTML documents to GitHub Pages, and
  • Adding support for 64-bit types in co_reduce

The most significant missing features in the currently implemented Caffeine functions are

  1. No support for derived type arguments to co_reduce and
  2. No support for the optional arguments in this_image() and num_images().

To reproduce the problem, execute

./install.sh
./build/run-fpm.sh run --example double-scalar
This commit
1. Fixes a gfortran-11 workaround for an inconsistent value
   for the above-referenced descriptor struct member.
2. Enables a previously commented test of caf_co_sum that now
   works with this PR's fix.
@rouson rouson requested review from bonachea and ktras February 25, 2022 07:16
This commit ensures that FPM_CC matches GASNET_CC during
installation.
This finishes a fix started in commit 4097a.
This commit updates the co_min test to use string lengths and
string array shapes that differ from those employed in the similar
co_max and co_reduce tests.
Switch caf_co_max_test from using 2D data to using 3D data.
Switch co_reduce string test from using allocatable scalar data
to using allocatable arrays of deferred-length strings.
@rouson rouson removed request for bonachea and ktras February 28, 2022 05:45
@rouson rouson merged commit 8df4882 into main Feb 28, 2022
@rouson rouson deleted the complex-double branch February 28, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant