Skip to content

Misc fixes#306

Merged
bonachea merged 6 commits intoBerkeleyLab:mainfrom
bonachea:misc-fixes
Mar 18, 2026
Merged

Misc fixes#306
bonachea merged 6 commits intoBerkeleyLab:mainfrom
bonachea:misc-fixes

Conversation

@bonachea
Copy link
Member

@bonachea bonachea commented Mar 12, 2026

A dumping ground for miscellaneous fixes I've stumbled across in the course of other work.

It's probably easiest to read/review this PR one commit at a time.

@bonachea bonachea marked this pull request as ready for review March 17, 2026 22:35
@bonachea bonachea requested a review from ktras March 17, 2026 22:35
@bonachea bonachea added this to the Caffeine 0.8.0 milestone Mar 17, 2026
Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add explicit casts to avoid some harmless integer sign warnings.
The bug workaround for GFortran's non-compliant c_funloc is moved
into a separate helper, where it can be called from Fortran.

This helps to improve the precision of the workaround, because it
enables placing its conditional invocation in the same translation
unit where the problematic call to c_funloc appears.
* Add `team_check` to validate invariants of team descriptors
* Add `team_check` assertions in various relevant places
* Change `parent_team` field of `initial_team` to null
Experience shows intermittent download failures from bitbucket
(especially from within GitHub actions, for some reason),
so enable automated retry.
@bonachea bonachea merged commit 6fa4f10 into BerkeleyLab:main Mar 18, 2026
36 checks passed
@bonachea bonachea deleted the misc-fixes branch March 18, 2026 20:07
@bonachea bonachea mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants