Adjust GASNETI_MEMCPY() for new GCC 16.1 warnings#3
Merged
Conversation
bonachea
reviewed
May 12, 2026
bonachea
requested changes
May 12, 2026
Member
bonachea
left a comment
bonachea
left a comment
There was a problem hiding this comment.
TY for the PR.
Source changes LGTM, two minor procedural requests.
This commit makes changes to the macro `GASNETI_MEMCPY()` (defined and used in public headers) to avoid `unused-but-set-variable` warnings. These warnings first appeared with the release of GCC 16.1.0 in builds of the Chapel runtime's GASNet-EX support. The fix is to replace the local/`static` accumulator previously used to provide a forced dereference of the source and destination addresses with use of `gasneti_unused_result()`. This eliminates the unused warnings, while retaining the dereference.
PHHargrove
force-pushed
the
gcc-16-memcpy-warning
branch
from
aa9280c to
26da9f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This single-commit PR addresses the root cause of the warnings which chapel-lang/chapel#28771 has suppressed (also in other third-party f/w fwiw).
Example warning:
Status:
Manually tested via
make testhello MANUAL_CFLAGS=-Werrorin a DEBUG build, and within a Chapel build tre.Commits:
Adjust GASNETI_MEMCPY() for new GCC 16.1 warnings
This commit makes changes to the
GASNETI_MEMCPY()(defined and used in public headers) to avoidunused-but-set-variablewarnings. These warnings first appeared with the release of GCC 16.1.0 in builds of the Chapel runtime's GASNet-EX support.The fix is to replace the local/
staticaccumulator previously used to provide a forced dereference of the source and destination addresses with use ofgasneti_unused_result(). This eliminates the unused warnings, while retaining the dereference.