Skip to content

"legacy" test drivers considered harmful #161

@bonachea

Description

@bonachea

The Julienne test suite currently includes a duplicate set of "legacy" test drivers, using an older, undocumented interface that directly invokes test_t%report, instead of the documented approach of constructing a test_harness_t from an array of test_fixture_t and invoking test_harness_t%report_results.
These legacy drivers are only activated for gfortran 14.2 and older. Those older gfortran versions do not test the current documented test harness interface in the Julienne test suite.

I suspect these legacy drivers are no longer actually required.
Moreover, this bifurcation is actively harmful to the Julienne test coverage, because it means Julienne CI is not testing the documented interface for these older gfortran versions.

I've manually tested using the "normal" (non-"legacy") driver using all of:

  1. Linux gfortran 14.2
  2. Linux gfortran 14.1
  3. Linux gfortran 13.4
  4. Linux gfortran 13.3

Ideally we should remove the unnecessary code duplication and use of undocumented interfaces embodied in these legacy drivers. If that's not possible for some reason, we should document (e.g. in comments) exactly why this ugly workaround is required.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions