Conversation
Collaborator
Author
|
Confirmed that the tests pass with the updated CI workflows from this branch: https://github.com/BerkeleyLearnVerify/Scenic/actions/runs/7268486842 |
Eric-Vin
changed the title
Collaborator
Author
|
Hmm, seems to exhibit an unrelated bug (and I believe it's the one we're working on patching in https://github.com/BerkeleyLearnVerify/Scenic/tree/OpendriveParser). |
dfremont
reviewed
Jan 10, 2024
dfremont
reviewed
Jan 11, 2024
dfremont
reviewed
Jan 11, 2024
dfremont
requested changes
Jan 11, 2024
Collaborator
dfremont
left a comment
dfremont
left a comment
There was a problem hiding this comment.
Looks great overall (hooray for simplifying the installation procedure!) -- just a few minor comments and our discussion offline about unifyMesh.
Collaborator
Author
Collaborator
Author
|
Alright with the new fix and pinned Manifold version we should be good to merge. |
dfremont
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move from OpenSCAD/Blender to Manifold, which is faster, more reliable, and can (soon) be installed via PyPi.
This is a WIP, as I developed it using a locally built Manifold wheel and modified version of Trimesh. Once this PR and this issue are implemented, I'll update this branch so that we can run CI and confirm everything works.
I'll also need to update the installation instructions and documentation, and figure out how we can detect non 2-manifold meshes and present a clean error to users, as I believe Manifold will rightly error on those. Right now some of them are detected on our end, but others aren't and that leaves some undefined behavior.